search

yWorks / svg2pdf.js

A javascript-only SVG to PDF conversion utility that runs in the browser. Brought to you by yWorks - the diagramming experts
MIT License
646 stars 96 forks source link

Fix building: peer dependency, es2016 #214

Closed edemaine closed 7 months ago

edemaine commented 2 years ago

I just tried building this myself, and ran into two issues:

  1. Modern NPM no longer installs peer dependencies automatically. So I added the required peer dependency tslib as a devDependency.
  2. Array.prototype.includes (as used in textchunk.ts on line 94) requires es2016, so I increased the version in .tsconfig.

With these changes, I can build. 🙂

HackbrettXXX commented 11 months ago

Which NPM version are you talking about? I could npm install/npm run build without any troubles with npm 9.5.0/node 19.7.0.

HackbrettXXX commented 7 months ago

Closing this, feel free to reopen.