search

yWorks / svg2pdf.js

A javascript-only SVG to PDF conversion utility that runs in the browser. Brought to you by yWorks - the diagramming experts
MIT License
655 stars 101 forks source link

Extended the regex for the markers #41

Closed stefano-caporale-wk closed 6 years ago

stefano-caporale-wk commented 6 years ago

In IE11 the value of start-marker, mid-marker and end-marker includes quotes ex: url(\"#mymarker\")

yGuy commented 6 years ago

If I am not mistaken, the complete change would be to change the regex like so: 

/url\([\"']?#([^\"']+)[\"']?\)/

That pull request is far too big for this change. @HackbrettXXX - can't you just update the code with the new regex the next time you do a modification?

HackbrettXXX commented 6 years ago

Sure. I'm gonna include it tomorrow.

stefano-caporale-wk commented 6 years ago

Thank you. I know I did a shitty pull request, I'm sorry for that. Just wanted to let you know the issue actually.