search

yWorks / yfiles-jupyter-graphs

The home of the Jupyter notebook graph visualization widget powered by yFiles for HTML
https://www.yworks.com/products/yfiles-graphs-for-jupyter
Other
133 stars 14 forks source link

Added missing pip install #12

Closed andrawaag closed 1 year ago

andrawaag commented 2 years ago

The notebook needs an additional pip install to work

yGuy commented 2 years ago

I think this was in a way intentionally left out in all the examples, because in order to play safe, you should install this from the console, or at least you need to restart the server in those cases where the most important dependeny (ipywidgets) has not yet been installed. In this case you would need to restart the server anyway and having the pip install right in the notebook makes it look sufficient, where it's not.

I don't know how other plugins are handling this. In any case I would rather either add the pip install to all examples (plus possibly a comment that you might have to restart the server, anyway if this is the first widget) or none, and instead document this more prominently.

What do you think? What's your experience with other widgets?