yWorks / yfiles-jupyter-graphs

The home of the Jupyter notebook graph visualization widget powered by yFiles for HTML
https://www.yworks.com/products/yfiles-graphs-for-jupyter
Other
173 stars 18 forks source link

Only 127.0.0.1 and localhost supported :( #29

Closed paltusplintus closed 1 year ago

paltusplintus commented 1 year ago

Describe the bug Getting a message: "The widget only permits use on 127.0.0.1 and localhost. In case this doesn't work for you, let us know on GitHub." When running the widget on https://go.dominodatalab.com/ platform. It is common for companies to use platforms like Domino or Databricks to do jupyter notebooking, where host might be different. Is there a particular reason for this restriction? Thanks.

Screenshots image

Desktop (please complete the following information): NAME="Ubuntu" VERSION="18.04.6 LTS (Bionic Beaver)" MS Edge browser

yGuy commented 1 year ago

Thanks. We are currently considering lifting this restriction and we will be white-listing more applications.

Is "dominodatalab.com" part of the domain (window.location) when you see that message? What would be the exact domain for "databricks"?

We are still hesitating to make this available for all domains. This is not for technical reasons, but purely commercial. See also: https://github.com/yWorks/yfiles-jupyter-graphs/discussions/28

paltusplintus commented 1 year ago

Thanks for your quick response and my compliments for a nice tool! Domino host may vary from company to company as far as I understand. Most likely a mask like "https://domino*" should work fine. The structure of url to the notebook for me would look like https://domino-dev.gsk.com/{username}/{project_name}/notebookSession/{run_id}/proxy/{port}/ But the -dev and .gsk part may vary depending on the company.

fskpf commented 1 year ago

With the latest release (v1.4.2), we added 'domino' to the allowed domains. So hopefully this should make it work on your end. In any case, please let us know.

paltusplintus commented 1 year ago

Thanks! It worked in Jupyter Notebook environment. Noticed the following issue in Jupyter Lab with v1.4.2 though: image

yGuy commented 1 year ago

This indicates that you need to restart the jupyter server, first. If you are absolutely sure that this also happens on a clean installation with a freshly started jupyter labs instance, please do get back and report more version details about the components you are using.

fskpf commented 1 year ago

@paltusplintus I noticed something similar while testing the updated widget in different environments:

In a https://mybinder.org/ environment, the widget worked in Jupyter Notebook but not in Jupyter Lab (although the error was different).

However, it fixed itself after clearing the cache and reloading the MyBinder page. It was not sufficient to just restart the kernel and run the notebook again.

I think this may be caused by an 'inline' installation of the widget. For example, if you install the widget within a notebook cell like so

%pip install yfiles-jupyter-graphs

In this case, make sure to reload the browser page as well.

However, in other environments, it just works out of the box.