search

ya0-yuan / pe

0 stars 0 forks source link

wrong error message for time format in appt #4

Open ya0-yuan opened 3 years ago

ya0-yuan commented 3 years ago

I followed the ug and in put the time in correct HH:MM format, but with potentially wrong value, the error message in the response box didnt not reflect that.

to reproduce: addappt 1 on/11-11-2020 24:30 dur/60 desc/Removal of braces. tag/Dental

image.png

nus-se-bot commented 3 years ago

Team's Response

The format of the time is HH:MM, where HH is a VALID hour as stated in the User Guide. However, 24 is not a valid hour i.e. there is no 24:00 in the 24 hour system clock but 00:00.

Hence, we do not consider 24:30 as a valid HH:MM format.

Additionally, we lowered the severity as such a case is unlikely to happen.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Inputing an invalid command was intentional. As it is possible for the user to make similar mistakes, a better reponse message could have been returned.

The current response could be shown when a user input a wrong format for the time, e.g. on/11-11-2020 2:30, while a different response such as "The input time does not follow 24 Hour System" could have been shown when the user didn't follow 24 hour system as what i did during testing, since it could be hard for the user to spot such error and correct himself. Such check could be easily done at development side.

I do agree the severity level could be low as it's not a common case, while it is better to respond a more accurate error message to the user.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]