ya0-yuan / pe

0 stars 0 forks source link

infinite number of appt can be added at the same time slot #7

Open ya0-yuan opened 3 years ago

ya0-yuan commented 3 years ago

There is no check for max number of appts that can be checked at the same time slot. The number of appt can be more than the number of doctor available, how am i gonna handle such situation?

image.png

nus-se-bot commented 3 years ago

Team's Response

From a rationale clinic receptionist's perspective, he or she is unlikely to add an ridiculous number of appointments on the same time slot, unless he or she is not serious about the job. Our UI is designed such that it accomodates the most common scenarios.

Also, our target user is receptionist in small clinics, not hospitals. Hence, we expect the overall number of appointments on a day to be reasonably small, not to the mention the number of appointments occuring at the same time, which is going to be even smaller.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with the statement above because we are not supposed to assume user behaviour ("he or she is unlikely to add an ridiculous number of appointments on the same time slot"). It is possible for users to make accidental mistakes, especially when they are unfamiliar with the product, and it is our job to handle all potential user mistakes. In this case, for an appointment to be legitimate, the baseline requirement is that there must be a doctor to handle the appointment. If an infinite number of appointments at the same timeslot can be added by a receptionist without any check, a possible case would be a client who booked an appointment enters the clinic but no doctor is available. Such bug could bring major inconvenience to the user. In addition, the sentence "we expect the overall number of appointments on a day to be reasonably small, not to the mention the number of appointments occuring at the same time, which is going to be even smaller" is also an assumption, but our job is to handle all possible scenarios, only so we can make our app bug-free. What if lots of clients happen to want to book the same time slot on a sunday afternoon, which is a possible case, and the app is unble to handle that? Or, if the clinic only has one doctor, but the receptionist accidentally added two appointments at the same time slot, how should we deal with such situation?