search

yaacov / tree-search-language

Tree Search Language (TSL) is a wonderful search langauge.
Apache License 2.0
60 stars 11 forks source link

Add support for ILIKE #11

Closed jhernand closed 5 years ago

jhernand commented 5 years ago

This patch adds support for the ILIKE operation.

jhernand commented 5 years ago

@yaacov please review.

yaacov commented 5 years ago

@jhernand a - do you need a release ? b - do you want to take https://github.com/yaacov/tree-search-language/issues/12 , it will require adding testing of "not like/ilike" that we are missing, and taking care of the walkers ( currently the semantic walker does not implement notOp, so that may be tricky ) ?

jhernand commented 5 years ago

Yes, we need a release.

I tried to do it in #13, but I didn't take into consideration the missing notOp implementation. Which walkers don't implement it?

yaacov commented 5 years ago

I tried to do it in #13, but I didn't take into consideration the missing notOp implementation. Which walkers don't implement it?

semantic: https://github.com/yaacov/tree-search-language/blob/master/pkg/walkers/semantics/walk.go#L225