search

yaacov / tree-search-language

Tree Search Language (TSL) is a wonderful search langauge.
Apache License 2.0
60 stars 11 forks source link

Remove NotLikeOp #13

Closed jhernand closed 5 years ago

jhernand commented 5 years ago

This patch removes the NotLikeOp operation because that is now implemented by the parser as a combination of Not and Like.

Fixes: https://github.com/yaacov/tree-search-language/issues/12

jhernand commented 5 years ago

@yaacov please review.

yaacov commented 5 years ago

Woo, that was fast !

yaacov commented 5 years ago

Do you want to add NotOp to sematic in this PR ?

jhernand commented 5 years ago

Yes, I will add the NotOp as otherwise this won't be correct.

jhernand commented 5 years ago

@yaacov I think I added the NotOp implemenation to the semantic walker. Please check. I also added a test to verify it. And I used ginkgo for that which requires some changes in the Makefile and in the Travis configuration. Hope that is acceptable.

yaacov commented 5 years ago

Hope that is acceptable.

will merge when green :-)

jhernand commented 5 years ago

Thanks for merging this @yaacov. I would appreciate if you can now make a new release.

yaacov commented 5 years ago

https://github.com/yaacov/tree-search-language/releases/tag/v3.9.0

jhernand commented 5 years ago

Thanks again @yaacov.