search

yaapu / FrskyTelemetryScript

A LUA telemetry script and widget for the Horus X10(S),X12 and Taranis X9D+,X9E,QX7 and X-Lite radios using ArduPilot frsky passthru protocol
GNU General Public License v3.0
432 stars 136 forks source link

Horus Widget 1.9.4 beta1 shows only disabled (CRSF) #116

Closed twistedwings closed 3 years ago

twistedwings commented 3 years ago

after upgrading from 1.8.1 the widget shows only text "disabled".

Radiomaster TX16S OpenTX 2.3.11

madjan06 commented 3 years ago

I have the same problem.

HORUS X10S OpenTX 2.3.1 Arduplane 4.1Beta Crossfire 3.78

In the telemetry-widget-settings I get the following error:

refresh():?:0: attempt to perform arithmetic on field 'terrainLastData' (a nil value)

yak-54 commented 3 years ago

Try update opentx to 2.3.11 ? opentx 2.3.1 is over 3 years old Firmware for that radio a lot of LUA changes

madjan06 commented 3 years ago

It is 2.3.10, sorry I missed a zero, it was a little bit late yesterday, but I try to update to 2.3.12 today. Maybe that helps

depeurvince commented 3 years ago

I got the same problem.

Radiomaster TX16S OpenTX 2.3.12 Arduplane 4.1Beta Crossfire 4.11

In the telemetry-widget-settings I get the following error:

refresh():?:0: attempt to perform arithmetic on field 'terrainLastData' (a nil value)

If I delete the widget and set it again, it works but at next startup it crashes again..

Any ideas?

yaapu commented 3 years ago

guys please try to download this dev version and let me know if it fixes the issue, simply overwrite what you have installed now thanks :-)

SD.ZIP

depeurvince commented 3 years ago

Thanks a lot, eager to try it! Unfortunately I won't be able to try before Monday. Wish you a nice weekend!

madjan06 commented 3 years ago

Hi, I have tested it, but I do not know if it is behaving properly.

First try it did not work, disconnected everything from power, repowered the Horus and saw the telemtry widget, no error. After that I powered my fc and got telemtry data and the widget worked fine. Then I disconnected the fc from power, the widget still worked, but as soon as I repower the fc the widget runs into the same error as before and I have to disable the widget and reenable it or restart the horus to get it working again.

If you need more Information I try my best to provide them, thanks a lot for your work ;-)

yaapu commented 3 years ago

@madjan06 do you get

refresh():?:0: attempt to perform arithmetic on field 'terrainLastData' (a nil value)

madjan06 commented 3 years ago

@madjan06 do you get

refresh():?:0: attempt to perform arithmetic on field 'terrainLastData' (a nil value)

Yes, exactly

depeurvince commented 3 years ago

Hi Alex,

I tried the dev version that you posted, the problem remain the same. The widget crashes at every startup, right after the FC initialisation and most probably randomly during the flight. Setting the widget again in the telemetry page makes it working until the next crash.

yaapu commented 3 years ago

I can't crash it, which OpenTX version and which ArduPilot version?

yaapu commented 3 years ago

frsky or crossfire?

madjan06 commented 3 years ago

@yaapu

@depeurvince wrote a few posts above that he uses the following: Radiomaster TX16S OpenTX 2.3.12 Arduplane 4.1Beta Crossfire 4.11

The only difference in my setup is, that I use a Horus x10s with OpenTX 2.3.10 instead of a Radiomaster TX16s.

depeurvince commented 3 years ago

Yes exactly! It crashed with openTX 2.3.11 as well. I did few flights yesterday, it crashes during the flight. It seems that it happens when there is a change between RF mode 1 and 2 but difficult to say while piloting..

yaapu commented 3 years ago

ok, guys sorry for not reading the whole thread :-)

depeurvince commented 3 years ago

No worries 😉

yaapu commented 3 years ago

I've found the bug :-) fix is coming

yaapu commented 3 years ago

please try this version and thanks for the feedback!

SD.ZIP

depeurvince commented 3 years ago

Great, congratulation, it seems to work! At least no more crashes at startup, will test in flight asap and give you the feedback.

Many thanks!

madjan06 commented 3 years ago

Seems to be working for me also, great work @yaapu 😉

yaapu commented 3 years ago

Great!

DarkSoulRL commented 3 years ago

Yes! ty, working for me too.

yaapu commented 3 years ago

Ok I'll close it, thanks everynody

padcom commented 3 years ago

Same problem with Taranis - is the fix merged to both versions?

padcom commented 3 years ago

Could you update the repository with the latest sources? Maybe create a branch with the latest sources? It is really hard to check the latest code and what kind of fixes you do if the source is not published. Only dev and master branches are visible, but those are ages old.

Pretty please?

yaapu commented 3 years ago

Yes, the repo is a bit behind, master a lot, dev 2 months. I'll see what I can do

padcom commented 3 years ago

@yaapu Do you think I should open the same issue for Taranis? I do get the same error, pretty much 100% of the time when I open the telemetry screen. Nothing works.

yaapu commented 3 years ago

@padcom it's the same issue, fixed on my dev branch, need some time to publish it, sorry

padcom commented 3 years ago

Btw, I checked the SD.zip on my Jumper T18 (otx 2.3.11) and this is what I get:

https://www.youtube.com/watch?v=s8n394-Xrks

When I try to open one of the telemetry screens I can see a brief flash as if the app would start and then the text "disabled" shows in the left-top corner of the screen. I am not receiving any data besides the last message about RC control being out.

yaapu commented 3 years ago

Could you update the repository with the latest sources? Maybe create a branch with the latest sources? It is really hard to check the latest code and what kind of fixes you do if the source is not published. Only dev and master branches are visible, but those are ages old.

Pretty please?

Hi repository updated, check the dev branch

yaapu commented 3 years ago

Btw, I checked the SD.zip on my Jumper T18 (otx 2.3.11) and this is what I get:

https://www.youtube.com/watch?v=s8n394-Xrks

When I try to open one of the telemetry screens I can see a brief flash as if the app would start and then the text "disabled" shows in the left-top corner of the screen. I am not receiving any data besides the last message about RC control being out.

better use the discuss forum I don't think this is a bug but a rather a config issue, I tried my script on the T18 in the sim and worked just fine

padcom commented 3 years ago

After reinstalling everything from the dev branch the problem is gone. Thanks. Will see if the bug will resurface.

yaapu commented 3 years ago

@yaapu Configuration issue?! Are quite serious? An out-of-the-box Jumper T18 with just added your telemetry script with no configuration done whatsoever (besides enabling the CRSF support) can have a configuration issue?

as strange as it may sound too many times (hundreds) it turned out to be some sort of user config issue, as trivial as forgetting to eject the SD and corrupting some files, so my first advice is always double check everything especially because such a big bug as not working on a clean install would have raised so many issue request that in no way it would have gone unnoticed, anyway glad you had it working