search

yabab-dev / ng2-codemirror

Angular2 CodeMirror component
MIT License
71 stars 30 forks source link

fixes #5 and #8 #9

Closed smnbbrv closed 7 years ago

smnbbrv commented 7 years ago

this fixes the issue with FormControl and adds the original codemirror as a dependency.

Could you release it, please?

yabab-dev commented 7 years ago

Hi @smnbbrv do you want to be a maintainer of this lib ? I don't have time atm to work on this, I can let you access to this repo and npm package if you want !

Maybe @sguiheux (https://github.com/sguiheux/ng2-codemirror-typescript) can be interested too ? This lib need to be converted to Typescript to use AoT I think...

smnbbrv commented 7 years ago

Hi @chymz

thank you, I'm not really sure I'll have time for this as well :( currently I just want to try it with one project. If it is going to go well it would definitely make some sense. I'll let you know when I'm ready :)

sguiheux commented 7 years ago

Hi @chymz ,

thank you, i'm currently working on another project that take lot of time :(. Maybe i can help but i will not be productive for the moment

smnbbrv commented 7 years ago

@chymz still, could you release at least this pull request? :)

yabab-dev commented 7 years ago

Yeah i'll do that today

smnbbrv commented 7 years ago

thank you @chymz !