search

yabacon / paystack-php

A PHP Wrapper for Paystack API - https://www.paystack.com
MIT License
109 stars 70 forks source link

http_error is false for guzzle #1

Closed crobytech closed 8 years ago

crobytech commented 8 years ago

Currently http_errors is being set as false which would mean that if the request failed for any reason the user would get only an empty result but not a description of what exactly went wrong.

I think the same thing is happening with curl as well. No error message is returned.

ibrahimlawal commented 8 years ago

Was intentional. This initial release includes no tests too. Want to try your hand on this and send a pull request? More than eager to merge.

crobytech commented 8 years ago

Just made a pull request. And yeah it would be nice to add some proper tests, would see if I can manage.

ibrahimlawal commented 8 years ago

Thanks! Your pull request has been merged and composer version updated.

crobytech commented 8 years ago

Aite, cool!

Why was it failing on Travis though ?

ibrahimlawal commented 8 years ago

I included PSR2 testing for the src folder to travis. Forces me to run 

$ ./vendor/bin/phpcbf --standard=PSR2 ./src/

each time I make a change to files in the src folder before committing.

crobytech commented 8 years ago

Oh okay. I'll go get Code sniffer then. Thanks

ibrahimlawal commented 8 years ago

It's included with the dev dependencies. so that command will work for you too.

crobytech commented 8 years ago

Thanks. Just ran it. Seen the diff.