yabeda-rb / yabeda-anycable

Collect performance metrics for AnyCable RPC server
MIT License
18 stars 2 forks source link

Incompatible with anycable < 1.1.0 and anycable-rail < 1.1.0 #1

Open dmitry-goncharuk opened 2 years ago

dmitry-goncharuk commented 2 years ago

anycable and anycabe-rails gems version below 1.1 do not have anycable-core as its dependencies. This causes errors, when adding yabeda-anycabl to a project with those gems installed.

This is caused because of a few things:

It is most likely to be common for Rails projects below version 6, as anycable-rails 1.1 can not be added to Rails <6 projects.

I guess it should be at least, mentioned in the Readme.

Envek commented 2 years ago

Middleware interface introduced in AnyCable 1.1 is absolutely essential for this gem to work.

So the only way to get it working in Rails before 6 is to convince @palkan to add support for Rails < 6 to anycable-rails 1.1.x :stuck_out_tongue_winking_eye:

palkan commented 2 years ago

anycable-rails 1.1.x supports Rails 5; see also https://github.com/anycable/anycable-rails/issues/164

dmitry-goncharuk commented 2 years ago

@Envek I totally get it. Issue is that you can install yabeda-anycable along with anycable-rails 1.0.x, which leads to an error.