yabeda-rb / yabeda-prometheus

Adapter to expose metrics collected by Yabeda plugins to Prometheus
MIT License
113 stars 18 forks source link

Make webrick logger configurable #17

Closed shouichi closed 2 years ago

shouichi commented 3 years ago

Background:

We run containers and collect their stdout/stderr using a log collecting agent. The agent marks stderr as error logs. Yabeda::Prometheus::Exporter internally uses Rack::CommonLogger without passing logger. In this case Rack::CommonLogger logs to stderr. As a result, simple webrick logs are marked as errors in our environment.

Possible solutions:

Thanks in advance.

Envek commented 2 years ago

Fixed in #19 and released in 0.8.0 (please note that logging now is disabled by default)

shouichi commented 2 years ago

Thank you!