Make exporter server logger configurable

yabeda-rb / yabeda-prometheus

Adapter to expose metrics collected by Yabeda plugins to Prometheus

MIT License

113 stars 18 forks source link

Make exporter server logger configurable #19

Closed palkan closed 2 years ago

palkan commented 3 years ago

And also disable logging by default 🙂

Envek commented 3 years ago

Okay, now we have two different implementations in two different prometheus adapters: here and in https://github.com/yabeda-rb/yabeda-prometheus-mmap/pull/4.

The question is: with which one we should stick (or maybe some hybrid?)

palkan commented 3 years ago

with which one we should stick (or maybe some hybrid?)

I think, that we shouldn't enable logs by default. And providing an ability to use a custom logger is also useful. However, we can add env var support to enable logs (or, maybe, we should stick to Yabeda.debug here? Makes sense to me).