search

yabeda-rb / yabeda-sidekiq

Yabeda plugin for complete monitoring of Sidekiq
MIT License
124 stars 15 forks source link

Add config option to allow retry count metrics segmented by queue #32

Closed SxDx closed 8 months ago

SxDx commented 8 months ago

This PR adds a new config option to enable the reporting of retry_count segmented by queue.

Envek commented 8 months ago

Thanks a lot for the pull request!

Can you please add configuration option to the README here: https://github.com/yabeda-rb/yabeda-sidekiq?tab=readme-ov-file#configuration ?

Envek commented 8 months ago

Test failures seems to be not related to your changes: tests were just outdated and stopped working. I fixed tests on the master branch.

SxDx commented 8 months ago

@Envek Thanks for fixing the tests. I merged upstream and updated the README.

Envek commented 8 months ago

Released in 0.11.0, please enjoy! Thanks!