yabhq / nuxt-fathom

Fathom analytics for NuxtJS
10 stars 2 forks source link

Module improvements #3

Open pi0 opened 3 years ago

pi0 commented 3 years ago

Thanks for this module! I'm adding few improvement ideas:

tillsanders commented 3 years ago

@pi0 Great suggestions, I created a PR to address these! I'm not 100 % sure about the runtime config, though. It works, but there might be a more elegant way? I was expecting this to contain the Nuxt Context, so I could access $config. Instead I had to access publicRuntimeConfig. See here: https://github.com/yabhq/nuxt-fathom/pull/4/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5R21