search

yabwe / medium-editor

Medium.com WYSIWYG editor clone. Uses contenteditable API to implement a rich text solution.
https://yabwe.github.io/medium-editor/
Other
16.04k stars 1.85k forks source link

Upgrade lodash 4.17.19 #1555

Closed roniemartinez closed 4 years ago

roniemartinez commented 4 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
New tests added? not needed
License MIT

Description

Upgrade lodash 4.17.19

--

Please, don't submit /dist files with your PR!

roniemartinez commented 4 years ago

Heavy dependency with Sauce Labs is breaking the CI

ksorv commented 4 years ago

Heavy dependency with Sauce Labs is breaking the CI

I think we should restrain from merging any more PRs before the tests are done. It might just make everything more and more complex, @arteconceito is working on tests I guess.

We should wait till then, or we must make the tests pass ourselves.

ksorv commented 4 years ago

Thanks for the PR, this'll be done soon. Closing.