ksorv
commented
4 years ago 1552
Tests passing again! Browser-Stack being utilized.
Some tests are not passing!
Closed ksorv closed 4 years ago
ksorv
commented
4 years ago Tests passing again! Browser-Stack being utilized.
Some tests are not passing!
ksorv
commented
4 years ago Firefox has errors which related to execAction(font props) of Core-API.
Not related to fonts probably!
Firefox 78.0 (Windows 10): Executed 617 of 617 (5 FAILED) (18.184 secs / 10.708 secs)
TOTAL: 5 FAILED, 612 SUCCESS
1) fontSize support old style
Core-API execAction
TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:239:20
<Jasmine>
2) fontName support new stle
Core-API execAction
TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:225:20
<Jasmine>
3) fontSize support new stle
Core-API execAction
TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:253:20
<Jasmine>
4) fontName support old style
Core-API execAction
TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:211:20
<Jasmine>
5) should pass opt directly to document.execCommand
Core-API execAction
TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:197:20
<Jasmine>
TOTAL: 5 FAILED, 612 SUCCESSSafari
Well, It sucks, I don't have a Mac to debug these.
Safari 8.0.8 (Mac OS 10.10.5): Executed 619 of 617 (4 FAILED) (3.472 secs / 3.6 secs)
TOTAL: 4 FAILED, 615 SUCCESS
1) should close the font name form when user clicks on cancel
Font Name Button TestCase Cancel
IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
2) should close the font name form when user clicks on cancel
Font Name Button TestCase Cancel
IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
TypeError: undefined is not a function (evaluating 'this.cleanupTest()') in spec/fontname.spec.js (line 26)
spec/fontname.spec.js:26:25
<Jasmine>
3) should close the font size form when user clicks on cancel
Font Size Button TestCase Cancel
IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
4) should close the font size form when user clicks on cancel
Font Size Button TestCase Font Size
IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
TypeError: undefined is not a function (evaluating 'this.cleanupTest()') in spec/fontsize.spec.js (line 26)
spec/fontsize.spec.js:26:25
<Jasmine>
TOTAL: 4 FAILED, 615 SUCCESSEdit: Was cause of CSS files not being included in srcFiles in Karma Config.
ksorv
commented
4 years ago IE is used by <2% users in the world. I think we should just drop it. @roniemartinez @arteconceito What you think about IE support!
arteconceito
commented
4 years ago IE is used by <2% users in the world. I think we should just drop it. @roniemartinez What you think about IE support!
In general public usage yes but believe me, there are still many companies (I mean at the enterpise level) that still and only use IE 11. I suppose this should be more a question of... Do we want to support it or not?
By the way, nice work with the tests migration. Unfortunately, I could not yet find the time I wished to contribute to the project!
ksorv
commented
4 years ago Yeah, I think the same too.
I think we should go for v10 and v11 as most people used to use ME cause it used to support all browsers.
Yeah, I got some free time(more like spirit than time) to do this. As i barely write tests.
And I'm still clueless on debugging these tests on IE and supporting them.
@arteconceito Direct me? I'll try to do it.
arteconceito
commented
4 years ago @sauravkhdoolia in my opinion supporting IE v11 is good enough and should cover most of IE user base as of today.
In order to debug IE I usually use a VM running IE11 on it. Firebug is also a good debugging extension as IE dev tools are not the best.
ksorv
commented
4 years ago I'll start there. Thanks brother.
ksorv
commented
4 years ago Hey @arteconceito It works on IE11 sometimes and sometimes it doesn't.
That is so weird to catch, Why sometimes an API is available in the IE browser, and sometimes it's not.
Here:
ksorv
commented
4 years ago @arteconceito It works in IE11, but sometimes it doesn't.
I don't know why?
Here:
ksorv
commented
4 years ago IE Errors found on BrowserStack.
IE 11.0 (Windows 10): Executed 617 of 617 (2 FAILED) (20.473 secs / 12.935 secs)
TOTAL: 2 FAILED, 615 SUCCESS
1) should change font name when select is changed
Font Name Button TestCase Font Name
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
at <Jasmine>
at Anonymous function (spec/fontname.spec.js:70:13)
at <Jasmine>
2) should revert font name when select value is set to empty
Font Name Button TestCase Font Name
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
at <Jasmine>
at Anonymous function (spec/fontname.spec.js:104:13)
at <Jasmine>
TOTAL: 2 FAILED, 615 SUCCESS
Description
--
Please, don't submit
/distfiles with your PR!