search

yackle / CLImageEditor

MIT License
2.22k stars 574 forks source link

Update for use_frameworks! CocoaPods feature #102

Closed agordeev closed 9 years ago

agordeev commented 9 years ago

Hey, thanks for the great library! Do you have any plans to update it to support use_frameworks! feature from CocoaPods? Right now it crashes when I try to instantiate CLImageEditor, because you use [NSBundle mainBundle] in CLImageEditorTheme (frameworks require to use [NSBundle bundleForClass:[self class]]). There are other issues with missing images, I believe they related to NSBundle issue as well.

yackle commented 9 years ago

I'll try. Please wait.

yackle commented 9 years ago

It is probably fixed. Could you check:

pod 'CLImageEditor', :git => 'https://github.com/yackle/CLImageEditor', :branch => "develop"
agordeev commented 9 years ago

Seems working! Big thanks. When will you merge the branches?

yackle commented 9 years ago

merged, thanks!