yackle / CLImageEditor

MIT License
2.21k stars 574 forks source link

CLTextTool landscape keyboard #196

Closed cliffjoyce closed 6 years ago

cliffjoyce commented 6 years ago

Using the 2017-10-18 build, the CLTextTool does not properly handle the keyboard in landscape orientations (the portrait keyboard always appears instead of the landscape keyboard).

To reproduce the issue: build the CLImageEditorDemo with Xcode 9 and launch the iPad Simulator in landscape orientation; tap the Edit button; tap the Text tool; tap the New button.

I think the issue is line 618 of _CLImageEditorViewController, because if I change line 618 to unconditionally return UIInterfaceOrientationMaskAll, then the landscape keyboard appears as expected.

A related issue: there's a UITextField that appears on screen while text is being typed. In the attached screenshot, you can see its blue insertion point just above the New button.

texttool-orientation-issue

yackle commented 6 years ago

Thanks for reporting!