search

yackle / CLImageEditor

MIT License
2.21k stars 574 forks source link

Multiple warnings regarding implicitly retaining self #211

Closed colincameron closed 6 years ago

colincameron commented 6 years ago

Environment:

When building an app using CLImageEditor, I can see 105 warnings, for example:

/Users/colin/git/[...]/Pods/CLImageEditor/CLImageEditor/ViewController/_CLImageEditorViewController.m:390:85: Block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior

Just in _CLImageEditorViewController.m, there are dozens of warnings:

screenshot 2018-03-29 12 41 51

yajra commented 6 years ago

@colincameron were you able to fix this warnings? TIA

-- Edit -- I was able to fix this warnings by adding self-> on each line.

colincameron commented 6 years ago

No I'm just ignoring the warnings for now, as I don't want to start editing files pulled from Cocoapods. I'll probably open a PR to fix this.

colincameron commented 6 years ago

Opened PR #214

yajra commented 6 years ago

Thanks for the feedback. BTW, be aware that the package seems to fail on XCode 9.4. I downgraded to XCode 9.3 and it works again properly. Getting an EXC_BAD_ACCESS error with 9.4 and I don't not have enough knowledge to fix it. :)

colincameron commented 6 years ago

Seems to be working fine for me on Xcode 9.4.1 - not sure what the problem could be sorry.

yajra commented 6 years ago

@colincameron I just tried recompiling on XCode 9.4 and it works well now. Must be some issue on my environment. Thanks!