Localize Done button on navigation bar

[vvit]

I think changing Done button title can also be useful. What do you think? Thanks.

[yackle]

That would be nice! Please wait to become ready.

[yackle]

I had just an idea. I think the following modification is better for compatibility of Localizable.strings.

    NSString *doneBtnTitle = [CLImageEditorTheme localizedString:@"CLImageEditor_DoneBtnTitle" withDefault:@""];

    if(doneBtnTitle.length>0){
        self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:doneBtnTitle style:UIBarButtonItemStyleDone target:self action:@selector(pushedFinishBtn:)];
    }
    else{
        self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(pushedFinishBtn:)];
    }

How about you?

[vvit]

Sounds good to me, thx!

On 28 січ. 2015, at 09:45, Sho Yakushiji notifications@github.com wrote:

I had just an idea. I think the following modification is better for compatibility of Localizable.strings.

NSString *doneBtnTitle = [CLImageEditorTheme localizedString:@"CLImageEditor_DoneBtnTitle" withDefault:@""];

if(doneBtnTitle.length>0){
    self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:doneBtnTitle style:UIBarButtonItemStyleDone target:self action:@selector(pushedFinishBtn:)];
}
else{
    self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(pushedFinishBtn:)];
}

How about you?

— Reply to this email directly or view it on GitHub.

[yackle]

merged, and modified 5d80b853f3206560c70cb014a625380be09298bd

Thanks!

[vvit]

@yackle thx, but you forgot to remove "CLImageEditor_DoneBtnTitle" = "Done"; from CLImageEditor.bundle/Resources/en.lproj/Localizable.strings to make it work as expected :)

[yackle]

it is probably fixed, please check it.