search

yacobylab / oo_special_measure

new object oriented special measure
GNU General Public License v2.0
1 stars 0 forks source link

default constructors #5

Open yacobyadmin opened 10 years ago

yacobyadmin commented 10 years ago

I think default constructors for all objects (or maybe almost all) should take a struct with the properly named fields.

pmaher86 commented 10 years ago

I understand the motivation for this, as it's very flexible, but I think it ultimately hurts code transparency. If we end up needing a ton of inputs to the constructors, I'd rather try to create a wrapper class that would make it explicit what the inputs are.

mikeyshulman commented 10 years ago

agreed! you might also imagine that we improve the experience of actually setting up a rack, and so that wrapper could be part of something bigger