search

yadav-rahul / TastyToast

:bread: Make your native android Toasts Tasty
2.04k stars 355 forks source link

enum for toast type #26

Open pkarira opened 7 years ago

pkarira commented 7 years ago

It would be better to use enum for toast type , storing them as integer seems to be a bad practice .

yadav-rahul commented 7 years ago

@deep110 What do you think about this? Also, Can you please review this PR #27 .

deep110 commented 7 years ago

@yadav-rahul enums are just used to group specific type of constants like that is done in #27. It is purely implementation viewpoint, there is no right or wrong from coding point of view. Though I would advise to switch to enum type. Because it would look cleaner and differentiate between Toast length and Toast type. And for the PR, it could be merged if you fix the error so that CI build is passed.