search

yadav-rahul / TastyToast

:bread: Make your native android Toasts Tasty
2.04k stars 355 forks source link

Added a default success toast and changing timer #8

Closed UshalNaidoo closed 8 years ago

UshalNaidoo commented 8 years ago

Added a default success toast

UshalNaidoo commented 8 years ago

@yadav-rahul you will need to merge this change first, before the other pull request ( #9) in order to resolve the conflicts

UshalNaidoo commented 8 years ago

@yadav-rahul @harshit211997 When do you think this PR will be accepted?

yadav-rahul commented 8 years ago

@UshalNaidoo What is the use of passing Toast Message twice ?

UshalNaidoo commented 8 years ago

@yadav-rahul The message is passed in once? The red lines are the code that has been removed, the green is the code that is added. There is a minus or plus in front of the line to indicate whether it was added or removed. If you have you not dealt with Pull Requests before, I can give you a quick run down of how it works.https://blog.codeship.com/github-code-review/