TheLocehiliosan
commented
4 years ago First, thank you for your packaging efforts. I appreciate it, and I'm sure Arch users will appreciate it even more.
I've gone through pains to make yadm run on a large number of systems, and gracefully downgrade when optional dependencies are not available. Indeed many aspects of it are written to the lowest common denominator. So for yadm, the systems supported make the coding very constrained. However, for the tests, I want to be as expressive as necessary, and less constrained. But that does translate to a constrained target the tests are designed to run within. This is how I settled upon Docker/Compose as the requirement for full testing. Docker is a reasonable testing dependency for most development machines.
I realize that Docker is NOT, a common dependency for automated packaging requirements. However, I also don't see the entire catalog of tests as necessary for packaging. After all, yadm is not compiled, but is a single Bash program.
I would like to help work through the testing troubles you've had. Perhaps some compromise can be reached.
The version requirements for the various linters are necessary, as the version determines what standards are enforced. I do not want any contributors surprised because their tests succeed, but my own do not (due to version differences). The tests are gracefully skipped if the supported version is missing.
Perhaps, one change could be to make gpg-based tests, gracefully skipped if the supported version is not present. Tests requiring "expect" could also be skipped if it isn't present. Based on the output above, that might allow you to run a large portion of the tests, and not have any failures.
Another possibility would be to write an appropriate test for the build environment. For example, the Homebrew formula implements a very brief test which creates a repo, and adds some content to that repo.
I'm not familiar with packaging for Arch, or what requirements might be present for the official Arch repos. Would skipping the tests that lacked dependencies solve these problems?
kgizdov
rasa
Describe the bug
The current testing environment for
yadmpresents some issues for crossplatform testing and deployment. Specifically, it requires a custom testing environment such as:/yadmpathshellcheck,pylint,flake8,yamllintgpg-agentTo reproduce
Steps to reproduce the behavior:
checkfunction during build:runner = <class 'conftest.Runner'> yadm_y = <function yadm_y..command_list at 0x7fea48e023a0>
paths = Paths(pgm='/build/yadm/src/yadm-2.0.1/yadm', root=local('/tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clea...ot/yadm/config'), encrypt=local('/tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm/encrypt'))
encrypt_targets = ['inc file1', 'inc dir/inc file2', 'globs file1', 'globs dir/globs file2', 'extest/inglob1']
overwrite = False, missing_encrypt = False, mismatched_phrase = False
test/test_encryption.py:181: AssertionError ---------------------------- Captured stdout setup ----------------------------- Initialized empty shared Git repository in /tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm/repo.git/ ----------------------------- Captured stdout call ----------------------------- EXPECT:set timeout 2 spawn "/build/yadm/src/yadm-2.0.1/yadm" "-Y" "/tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm" "encrypt" expect { "passphrase:" {send "ExamplePassword\r"} timeout {close;exit 128} } expect { "passphrase:" {send "ExamplePassword\r"} timeout {close;exit 128} } expect eof foreach {pid spawnid os_error_flag value} [wait] break exit $value Runner(['expect']) RUN: code:1 RUN: input: set timeout 2 spawn "/build/yadm/src/yadm-2.0.1/yadm" "-Y" "/tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm" "encrypt" expect { "passphrase:" {send "ExamplePassword\r"} timeout {close;exit 128} } expect { "passphrase:" {send "ExamplePassword\r"} timeout {close;exit 128} } expect eof foreach {pid spawnid os_error_flag value} [wait] break exit $value RUN: stdout: spawn /build/yadm/src/yadm-2.0.1/yadm -Y /tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm encrypt Encrypting the following files: extest/inglob1 globs dir globs file1 inc dir/inc file2 inc file1
gpg: WARNING: unsafe permissions on homedir '/build/yadm/src/yadm-2.0.1/work/yadm/.gnupg' gpg: keybox '/build/yadm/src/yadm-2.0.1/work/yadm/.gnupg/pubring.kbx' created gpg: problem with the agent: Permission denied gpg: error creating passphrase: Operation cancelled gpg: symmetric encryption of '[stdin]' failed: Operation cancelled ExamplePassword ERROR: Unable to write /tmp/pytest-of-builduser/pytest-0/test_symmetric_encrypt_clean_e0/root/yadm/files.gpg
RUN: stderr: expect: spawn id exp4 not open while executing "expect eof" ... =========================== short test summary info ============================ SKIPPED [1] /build/yadm/src/yadm-2.0.1/test/test_syntax.py:18: Unsupported shellcheck version SKIPPED [1] /build/yadm/src/yadm-2.0.1/test/test_syntax.py:27: Unsupported pylint version SKIPPED [1] /build/yadm/src/yadm-2.0.1/test/test_syntax.py:40: Unsupported flake8 version SKIPPED [1] /build/yadm/src/yadm-2.0.1/test/test_syntax.py:49: Unsupported yamllint version FAILED test/test_encryption.py::test_symmetric_encrypt[clean-encrypt_exists-matching_phrase] FAILED test/test_encryption.py::test_symmetric_encrypt[clean-encrypt_exists-mismatched_phrase] FAILED test/test_encryption.py::test_symmetric_encrypt[overwrite-encrypt_exists-matching_phrase] FAILED test/test_encryption.py::test_symmetric_encrypt[overwrite-encrypt_exists-mismatched_phrase] FAILED test/test_encryption.py::test_symmetric_decrypt[decrypt-archive_exists-correct_phrase] FAILED test/test_encryption.py::test_symmetric_decrypt[list-archive_exists-correct_phrase] FAILED test/test_encryption.py::test_offer_to_add[tracked] - AssertionError: ... FAILED test/test_encryption.py::test_offer_to_add[untracked_answer_y] - Asser... FAILED test/test_encryption.py::test_offer_to_add[untracked_answer_n] - Asser... FAILED test/test_encryption.py::test_encrypt_added_to_exclude - AssertionErro... ========== 10 failed, 325 passed, 4 skipped, 211 deselected in 54.69s ==========