search

yadobler / pe

0 stars 0 forks source link

after `find` command, `add` command resets displayed list, but `edit` re-filters the list instead #12

Open yadobler opened 3 days ago

yadobler commented 3 days ago

Summary

After using the find command, using the edit command will result in the list updating with the previous find constraint, but add results in the list being reset and all persons being shown.

Steps to reproduce

Optional: enter clear to start with clean slate, but this works regardless

  1. enter add n/Bob
  2. enter find Bob. There should only be 1 person named named Bob that shows
  3. enter edit 1 n/Tom
  4. observe list is now blank as there is no match for bob as per (2)
  5. enter list to reset view. There should be one person called Tom
  6. enter find Tom. Similar to (2)
  7. enter add n/Josh
  8. observe list resets and everyone (i.e. Josh and Tom) can be seen

Expected

Either find constraint is maintained for both, or both commands reset the view.

Observed

(2)

image.png

(4)

image.png

(6)

image.png

(8)

image.png

Tester Information

System Information:

Java version:

nus-se-script commented 7 hours ago

Team's Response

This is done intentionally as editing uses the displayed list as a reference for the index and it is most intuitive for the user to immediately be able to see the edited contact. Changing the filtered/displayed list after edit will confuse the user and they will be unable to identify the index of the contact edited.

However, when adding a new person, the person will likely not be on the current filter. Hence, it is more intuitive to reset the filter list to show all people for the user to check that the contact was added successfully.

This difference in behaviour is intended for a more intuitive user experience.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > Changing the filtered/displayed list after edit will confuse the user and they will be unable to identify the index of the contact edited.

I got confused when I edited the contact and the contact disappeared since it no longer matched the filter criterion. Lets say I realised I spelled "Bernice Yoh" as "Bernice Yu" wrongly and I also need to edit the game:

  1. I type find Yu
  2. I identify Bernice Yu as index 1
  3. I type edit 1 n/Bernice Yoh
  4. The contact disappears
  5. What index do I use now to edit with editgame ?

How do I know the contact was successfully edited - the message says "success" but my first thought is "Did I just delete my contact or corrupted the address book?"

To be honest, "they will be unable to identify the index of the contact edited" is literally the current situation that I am in after the edit command because, what is the index of the contact that is no longer visible?

From what I understand, the "intuitive" idea would be if the person list was not refreshed but only show the previous result with the new edits.

Also this is not documented in the UG. I will definitely assume the app deleted my contact after editing it, and wrongly assume the app is faulty and immediately give up.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]