yadomi / node-red-contrib-philipshue-events

Implements the Philips Hue API v2 EventSource as a node-red node
MIT License
13 stars 2 forks source link

Short question: why node-red >=2.2.2 ? #17

Closed windkh closed 1 year ago

windkh commented 1 year ago

First, thanks for your great work.

Your package.json contains the following limitation "node-red": { "version": ">=2.2.2",

Is there any 2.2.2 specific feature that you use in your nodes or why do you need that? Could it be >2.0.0, too?

yadomi commented 1 year ago

Hi,

the node mostly based on the eventsource package that only require Node 12 (see: https://github.com/EventSource/eventsource/blob/master/package.json#L49) and Node 12 is required since NodeRED 2.0.0.

The node don't use any specific 2.2.2 feature, so I guess it should work. I'll do some testing ASAP and release a version that change the limitation if everything works properly

windkh commented 1 year ago

Thanks

andesse commented 1 year ago

@yadomi wow, thanks for adding my flow friend! 🙏🏻

yadomi commented 1 year ago

@windkh I've publised version v1.5.2 that should work with NodeRED >= 2.0.0