search

yadudoc / cloud_kotta

Enabling Secure and Scalable Data Analytics in the Cloud
https://turingcompute.net
Apache License 2.0
16 stars 10 forks source link

[bug] Refreshing submit_task page resubmits task #22

Open bartleyn opened 8 years ago

bartleyn commented 8 years ago

After submitting a task, you are prompted with the confirmation page at turingcompute.net/submit_task. If you refresh that page, you end up resubmitting the same job, as you are presented with a new job-id, and a new task is listed in your 'My jobs' page.

Reproducing this issue

This is readily reproducible by taking the Hello World - Bash published job, submitting the task, refreshing the page, and checking your listed jobs.

yadudoc commented 8 years ago

On a scale of 0 to 5 (5 being super annoying), how bad is this ?

I can't think of a way to prevent this easily. I also see that when I press the refresh button a confirm form resubmission popup loads that asks the user to confirm if he/she wants to repeat the action.

form_resubmission

bartleyn commented 8 years ago

It doesn't bother me very much, but I can imagine that resubmitting a very long task accidentally and incurring unnecessary charges would be annoying to some people. What stands out to me though is that refreshing that page after it had been sitting overnight also resubmitted the job. It might be nice to be taken to the job page after some time.

yadudoc commented 8 years ago

I think every time you attempt to resubmit a job, you get the same form re-submission pop-up which should prevent accidental re-submissions. Secondly, if someone does accidentally resubmit a job, you can still cancel it. I think we should leave this closed until someone else complains.

However if you think we should simply have a better warning note on the job submit confirmation page, that can be done.