search

yadutaf / docker-machine-driver-ovh

OVH Cloud driver for Docker Machine
https://www.ovh.com/us/cloud/instances/
80 stars 25 forks source link

Fix for endpoint api selection. #29

Closed kfletche closed 7 years ago

kfletche commented 7 years ago

Quick fix to allow api selection outside the european endpoint.

yadutaf commented 7 years ago

Oh! you're completely right. I'm sorry I forgot this one... Would you mind adding a CLI flag along with its documentation ?

kfletche commented 7 years ago

Give it a try now.

yadutaf commented 7 years ago

It works perfectly. Thanks! You could even set the default to empty string like for --ovh-consumer-key, this should trigger the default path in https://github.com/ovh/go-ovh/blob/master/ovh/configuration.go#L66 and bring support for the environment ($OVH_CONSUMER_KEY) and conf file (.ovh.conf) based API configuration ;)

I can do this if you want.

kfletche commented 7 years ago

Good call. You clearly know your api wrapper better than I :)

yadutaf commented 7 years ago

Thanks a lot ! I'll add the tiny missing bit in the doc later today.