Prevent scrolling to top on formatting

yaeda / inkdrop-prettier

https://my.inkdrop.app/plugins/prettier

MIT License

9 stars 1 forks source link

Prevent scrolling to top on formatting #3

Closed craftzdog closed 3 years ago

craftzdog commented 3 years ago

Hi, thanks for creating this plugin!

I found an issue that the cursor position moves to the top on formatting. That's because Inkdrop tries to update the editor again when detecting the CodeMirror's state change to maintain its internal state consistency. So, you have to update not only CodeMirror but also the internal state. This PR should fix the issue.

craftzdog commented 3 years ago

FYI: The badges in README are broken :)

yaeda commented 3 years ago

@craftzdog Thanks for your PR.

I also found this issue and am just thinking of solutions. I'm very happy to get a PR from you.

FYI: The badges in README are broken :)

I'll fix it soon 😄

craftzdog commented 3 years ago

Great! Have a nice day.