search

yaegassy / coc-ansible

ansible-language-server extension for coc.nvim
https://www.npmjs.com/package/@yaegassy/coc-ansible
MIT License
71 stars 3 forks source link

Change package ansible-language-server to @ansible/ansible-language-server? #2

Closed yaegassy closed 2 years ago

yaegassy commented 2 years ago

Ref: https://github.com/ansible/ansible-language-server/pull/10

It looks like it has not been published to npm yet.

ganeshrn commented 2 years ago

@yaegassy The work is in progress. Linking the right PR https://github.com/ansible/ansible-language-server/pull/18 After @ansible/ansible-language-server is published we will deprecate the ansible-language-server package.

yaegassy commented 2 years ago

@ganeshrn Thanks for the info!!!

yaegassy commented 2 years ago

I've seen @ansible/ansible-language-server released, but it's currently in beta (v0.2.2-beta).

webknjaz commented 2 years ago

I think we'll release v0.2.3 soon'ish.

yaegassy commented 2 years ago

@webknjaz Thanks for the info. There are a few behaviors that are bothering me at the moment.

After the next version of vscode-ansible or ansible-language-server is officially released, I will do a full-scale check and report an issue if necessary. 🙇

yaegassy commented 2 years ago

@webknjaz By the way, I would like to confirm one thing.

If ansible-lint is not installed in the Python environment, for some reason, the "ansible-playbook" --syntax-check error is output. https://github.com/yaegassy/coc-ansible/issues/8#issue-1022310383

Why does ansible-playbook output an error if ansible-lint is not present?

Is this a problem only with my extension? Is this a problem that is not reproduced by vscode-ansible?

webknjaz commented 2 years ago

@yaegassy the way @priyamsahoo implemented this is that if there's no ansible-lint, then the built-in syntax check is used as a fallback.

yaegassy commented 2 years ago

@webknjaz Thanks for the explanation. I understand now.

However, this is a file on the "role" side, not the "playbook". Do you mean to run --syntax-check on the role-side YAML file as well?

webknjaz commented 2 years ago

That one is probably a bug. I think @priyamsahoo is currently working on adding some heuristics for identifying whether something is a playbook or just a list of the role tasks. This was mentioned in #ansible-devtools on IRC/Matrix earlier today but I'm not sure if there's a formal issue yet.

yaegassy commented 2 years ago

Thank you. My personal concerns have been resolved. 🙇

yaegassy commented 2 years ago

MEMO: Confirmed release of ansible-language-server v0.2.4

ganeshrn commented 2 years ago

@yaegassy Please do raise an issue here https://github.com/ansible/ansible-language-server/issues for tracking purposes. @priyamsahoo is currently working on fixing the issue.

ganeshrn commented 2 years ago

Please ignore my earlier comment. There is already an issue raised https://github.com/ansible/ansible-language-server/issues/81

priyamsahoo commented 2 years ago

Hey all, Hoping that this PR fixes the issue: https://github.com/ansible/ansible-language-server/pull/89

yaegassy commented 2 years ago

@priyamsahoo I checked the syntax-check-task-files branch in my environment. I confirmed that the problem had been resolved.

yaegassy commented 2 years ago

(TODO: Next official release of "ansible-language-server", switch to @ansible/ansible-language-server.)

priyamsahoo commented 2 years ago

@priyamsahoo I checked the syntax-check-task-files branch in my environment. I confirmed that the problem had been resolved.

Thank you :)