search

yafred / leaflet-responsive-popup

This plugin overrides L.Popup to remove the need to move the map to be able to see the content of the popup.
https://yafred.github.io/leaflet-responsive-popup/
BSD 2-Clause "Simplified" License
90 stars 20 forks source link

Angular compatibility #10

Closed emilyspitzer closed 5 years ago

emilyspitzer commented 5 years ago

Hi, Has anyone written libraries to make this compatible with Angular 6? Thanks! Emily

yafred commented 5 years ago

Hi,

make this compatible with Angular 6

Can you expand on what this means ?

manojguptatn commented 5 years ago

so we have used https://github.com/Asymmetrik/ngx-leaflet in our angular application. We could not find the responsive popup library as yours which is compatible with ngx-leaflet. We wanted to check if you are planning to convert the js version with ngx-leaflet supported version.

The goal i have is to implement your solution on responsive popup in ngx-leaflet.

Please guide me in this regard.

emilyspitzer commented 5 years ago

so we have used https://github.com/Asymmetrik/ngx-leaflet in our angular application. We could not find the responsive popup library as yours which is compatible with ngx-leaflet. We wanted to check if you are planning to convert the js version with ngx-leaflet supported version.

The goal i have is to implement your solution on responsive popup in ngx-leaflet.

Please guide me in this regard.

Yes, we are hoping to not have to translate into typescript from scratch.

yafred commented 5 years ago

Sorry for the delay. I was a newbie to Angular...

I think I fixed the issue (needs leaflet-responsive-popup 0.6.3 minimum)

Please take a look at https://github.com/yafred/ng-leaflet-responsive-popup

I had a quick look at https://github.com/Asymmetrik/ngx-leaflet but I don't get what the added value is (I need more time)

manojguptatn commented 5 years ago

Sorry for replying you late.We all wish you a merry Christmas and happy new year.

Many thanks for quickly replying to this.

sure I will wait, I would love to contribute to this repository.

I will too try.

yafred commented 5 years ago

Happy new year!

https://github.com/yafred/ngx-leaflet-responsive-popup/

emilyspitzer commented 5 years ago

Thank you, this was super helpful! Happy New year to you as well!