search

yafred / leaflet-responsive-popup

This plugin overrides L.Popup to remove the need to move the map to be able to see the content of the popup.
https://yafred.github.io/leaflet-responsive-popup/
BSD 2-Clause "Simplified" License
90 stars 20 forks source link

Close button is malfunctioning and redirect browser to #close #23

Open tkempken opened 2 years ago

tkempken commented 2 years ago

I've notices issues when users press the close button they will be redirected to anchor #close. Based on used some application routers this will led to issues without real requirement. From my understanding of the code this is unnecessary as the close button event will be catched without relations to the anchor.

closeButton.href = '#close';

yafred commented 2 years ago

The code is taken from Leaflet https://github.com/Leaflet/Leaflet/blob/v1.8.0/src/layer/Popup.js#L203

So, I think you should submit the issue there first.

This plugin only modifies the positioning of the popup, the rest follows the original L.Popup() code

andercarrera commented 1 year ago

I am currently struggling with that one, I think it may be related somehow by propagation