Open clxxiii opened 3 months ago
I think if you are not going to allow for mappools to be reused between tournaments, then go for the MappoolSection solution, else adding a ModMultiplier-like model which links to the settings would allow for the double pick/ban restrictions to change on a per map basis (assuming per map Setting objects are the reason why a MapInPool can be linked to a Settings). This is not a problem you wouldn't be able to work around but it is unnecessary.
But if you are going to allow for mappools to be reused between tournaments, MappoolSection shouldn't be used as the exemption from the double pick rule would be baked into the mappool's definition, even if the settings of the tournament change in between. That being said, I think a DoublePickExemption as opposed to a DoublePickRestriction model would be more useful as you would need to write less data to set up double picking/banning.
Previously, the were stored in the tournament settings, but ideally with the new block system, it would be a property applied to the block. The issue, is that many tournament apply the "no double picking except NM" rule, which allows players to double pick NM, but not anything else. If the double pick property is simply stored in block section, this is impossible
Possibilities: