search

yagamiapp / yagami

An auto-ref and tournament manager for osu!
https://yagami.clxxiii.dev
MIT License
7 stars 1 forks source link

Consistent missed ban behaviour & ABBA Bans #90

Open clxxiii opened 2 years ago

clxxiii commented 2 years ago

Take a 2 ban match for example: If Team A has banned once, and it's Team B's turn to pick, if the timer runs out, Team A will get two bans, and Team B will get one ban,

If Team A hasn't been banned, and their timer runs out, priority will switch to Team B, and both teams will get two bans

The expected behavior is that both cases are the same, whether the ban is skipped, or you lose priority

clxxiii commented 4 months ago

To add consistency, bans should be implemented in a "queue" style system, where if you miss your timer, it gets appended to the end of the queue. image

Using an architecture like this should also make implementing an ABBA, ABAB, or AABB ban pattern possible.