search

yagmurs / AzureStack-VM-PoC

66 stars 71 forks source link

Params discrepancies #1

Closed erjosito closed 6 years ago

erjosito commented 6 years ago

Great repo! I found some discrepancies in the parameters. For exmaple, adminUsername is in the params file, but not needed by the template. Same goes for location and public IP. I personally replaced the adminUsername variable in the template by a parameter, and deleted the rest of the params from the params file.

Let me know if you want a pull request with my changes

yagmurs commented 6 years ago

I have done some changes downloading files to handle changes on ASDK 1712 files. Adminusername parameter was intentionally left as variable. ASDK setup is using "Administrator" itself and Azure does not allow me to set "Administrator" as username. So this parameter later on are passed to post-config script to rename user to Administrator. As long as you passed to posts-script it should work.