search

yahehe / Nancy.Swagger

Nancy plugin for generated API documentation in Swagger format.
MIT License
133 stars 60 forks source link

Starts Swagger/OpenAPI 3 #133

Closed jnallard closed 7 years ago

jnallard commented 7 years ago

I created a new branch called swagger-3 which can be used to capture our progress towards Swagger/OpenAPI 3.

This change is very minimal - I created this PR just to bring attention to the new branch.

Is AppVeyor going to push NuGet packages when the swagger-3 branch is merged into? We don't want to push any packages yet.

yahehe commented 7 years ago

Not sure if Appveyor will publish or not, I would hope not. I can check later. If we disable package creation on the branch then that would effectively disable publishing

yahehe commented 7 years ago

Honestly we might even want to just create a new Nancy.OpenAPI repository and start there (we can clone this over so we aren't starting from scratch)

jnallard commented 7 years ago

I don't see the point in starting a new repository.

Edit: (didn't mean to hit comment so early) This project is still doing the same thing, but supporting a new version of swagger. It's the same process from when we upgraded from 1.4 to 2 - except for the name is different. I could change the package names so they would be uploaded to different nuget packages. I just don't see it as a new project. Once we get v3 working, we'll stop actively supporting v2.

yahehe commented 7 years ago

My main thought process is that continuing with the name Nancy.Swagger will be confusing to consumers of the package looking to use OpenAPI 3. I'm probably over-thinking that point. That said I guess it wouldn't make sense to lock down the Nancy.OpenAPI namespace now since we don't have it implemented yet (someone else might get to it first), so +1 for developing on the feature branch

yahehe commented 7 years ago

Only master and 1.4.3-stable are configured for builds, only master is configured for publishing. I can configure this branch to build but not publish

yahehe commented 7 years ago

Don't think I turned off publishing correctly...

jnallard commented 7 years ago

Did you delete the nuget packages?

yahehe commented 7 years ago

No, I will