search

yahehe / Nancy.Swagger

Nancy plugin for generated API documentation in Swagger format.
MIT License
133 stars 60 forks source link

Fix xunit warnings and add some tests #140

Closed catcherwong closed 7 years ago

catcherwong commented 7 years ago

For this PR I have done the following works

  1. Fix xunit warnings after upgrading to version 2.3.0
  2. Add some new tests for Swagger.ObjectModel
  3. ApiKeySecuritySchemeBuilder should return a new SecurityScheme object with Description
yahehe commented 7 years ago

Uh you have some weird merge commit from 3 years ago at the beginning of this. Can you please rebase your changes off master?

catcherwong commented 7 years ago

@yahehe Do you mean this class ApiKeySecuritySchemeBuilder ?

yahehe commented 7 years ago

I mean this commit that somehow made it into your pull request: "Merge pull request #3 from yahehe/master" https://github.com/yahehe/Nancy.Swagger/pull/140/commits/ac915cbf74e0a85a59b14f4f418caef09f724151

catcherwong commented 7 years ago

All right , I understand it ! I will rebase at first !