search

yahiaelgamal / smartsoft-14

Smartsoft 2014 repo
1 stars 4 forks source link

T1 lotfy 1.11 #302

Closed lotfy1893 closed 10 years ago

lotfy1893 commented 10 years ago

@kalamoni @andrewkhouzam @abdelrahmansakr to be reviewed #252

kalamoni commented 10 years ago

@lotfy1893 doc reopened. please check notes

abdelrahmansakr commented 10 years ago

@lotfy1893 Scenario reopened ! Whenever I try to run the server (rails s) I get the following error: screen shot 2014-05-14 at 12 34 47 am

kalamoni commented 10 years ago

@lotfy1893 some notes have been taken care of. while some not. and new one arose.

lotfy1893 commented 10 years ago

@kalamoni the documentation issues are now updated !

lotfy1893 commented 10 years ago

@abdelrahmansakr you can reCheck and review !

lotfy1893 commented 10 years ago

@andrewkhouzam you should be reviewing code by now as it's ready to be merged !

abdelrahmansakr commented 10 years ago

@lotfy1893 Scenario verified.

kalamoni commented 10 years ago

@lotfy1893 documentation reopened. Please take care of the note I put. thanks for your tolerance. Hope this ends soon :v:

andrewkhouzam commented 10 years ago

Please apply the new code conventions. using https://github.com/DevYah/smartsoft-14/wiki/New-Code-Formatting-Conventions

lotfy1893 commented 10 years ago

@andrewkhouzam i tried to use the ruby beautify but there is no difference made by this gem i think it will be redundant to use such method.

lotfy1893 commented 10 years ago

@andrewkhouzam i used the gem to beautify as much as i could plz review as exist dependecies and aslo don't forget to change the adminstration check to be on 'healthygrocery@gmail.com' instead of 'admin@gmail.com' thank you @andrewkhouzam :+1:

lotfy1893 commented 10 years ago

@abdelrahmansakr the feature you asked for is now handled when you asked to me to notify the user to confirm at the login page!

kalamoni commented 10 years ago

@lotfy1893 Good job.. Just a few notes left [new one added].. Doc reviewing still reopened.. We're almost there! :+1:

lotfy1893 commented 10 years ago

@kalamoni give it a look ...i hope you don't give notes above others documentations :dancer:

kalamoni commented 10 years ago

@lotfy1893 finally.. doc verified :+1:

andrewkhouzam commented 10 years ago

@lotfy1893 Please follow the new code conventions using the code beautifier (It is in wiki)

lotfy1893 commented 10 years ago

@andrewkhouzam i folllowed it copied pasted the code from the terminal couldn't do more!

lotfy1893 commented 10 years ago

@andrewkhouzam plz review for the merge~

lotfy1893 commented 10 years ago

@andrewkhouzam been handled :)

andrewkhouzam commented 10 years ago

healthygrocery@gmail.com Password?

andrewkhouzam commented 10 years ago

Very Good Job Lotfy! I will try every possible link now!

andrewkhouzam commented 10 years ago

I need to modify it myself because It is the GUI Issues! So I will commit on this branch!