Closed lotfy1893 closed 10 years ago
@lotfy1893 doc reopened. please check notes
@lotfy1893 Scenario reopened ! Whenever I try to run the server (rails s) I get the following error:
@lotfy1893 some notes have been taken care of. while some not. and new one arose.
@kalamoni the documentation issues are now updated !
@abdelrahmansakr you can reCheck and review !
@andrewkhouzam you should be reviewing code by now as it's ready to be merged !
@lotfy1893 Scenario verified.
@lotfy1893 documentation reopened. Please take care of the note I put. thanks for your tolerance. Hope this ends soon :v:
Please apply the new code conventions. using https://github.com/DevYah/smartsoft-14/wiki/New-Code-Formatting-Conventions
@andrewkhouzam i tried to use the ruby beautify but there is no difference made by this gem i think it will be redundant to use such method.
@andrewkhouzam i used the gem to beautify as much as i could plz review as exist dependecies and aslo don't forget to change the adminstration check to be on 'healthygrocery@gmail.com' instead of 'admin@gmail.com' thank you @andrewkhouzam :+1:
@abdelrahmansakr the feature you asked for is now handled when you asked to me to notify the user to confirm at the login page!
@lotfy1893 Good job.. Just a few notes left [new one added].. Doc reviewing still reopened.. We're almost there! :+1:
@kalamoni give it a look ...i hope you don't give notes above others documentations :dancer:
@lotfy1893 finally.. doc verified :+1:
@lotfy1893 Please follow the new code conventions using the code beautifier (It is in wiki)
@andrewkhouzam i folllowed it copied pasted the code from the terminal couldn't do more!
@andrewkhouzam plz review for the merge~
@andrewkhouzam been handled :)
healthygrocery@gmail.com Password?
Very Good Job Lotfy! I will try every possible link now!
I need to modify it myself because It is the GUI Issues! So I will commit on this branch!
@kalamoni @andrewkhouzam @abdelrahmansakr to be reviewed #252