search

yahiaelgamal / smartsoft-14

Smartsoft 2014 repo
1 stars 4 forks source link

FINAL GUI #348

Closed andrewkhouzam closed 10 years ago

andrewkhouzam commented 10 years ago

@sedramina @mahmoudawadeen @mostafa-adel @kalamoni @ZzimBoo91 @osherifo I need one scenario and one code verifier!

ZzimBoo91 commented 10 years ago

Code verified @andrewkhouzam

mahmoudawadeen commented 10 years ago

@andrewkhouzam scenario verified

tonyfoti commented 10 years ago

@andrewkhouzam Why would you delete someone else code without referring to him ?!

andrewkhouzam commented 10 years ago

@tonyfoti Because you messed other's people work!

tonyfoti commented 10 years ago

@andrewkhouzam You should have told me or asked me to review or do whatever to do else than removing a whole file code content I made which more than one developer relied on. Our page we worked on me and desouki and others is really messed. And I guess what you were intending to fix regarding the bootstrap was not even fixed. You need to modify something remove something or do whatever you may need ask the developer who did that thing not remove his work without refering to him. I know you wanted to have a good frontend but I wish you were more cooperative than that. But it's ok all that is for our sake and don't worry we made a good job even though problems exist.

andrewkhouzam commented 10 years ago

@tonyfoti I see that you do not understand what you messed up! So when you do please tell me!

andrewkhouzam commented 10 years ago

@tonyfoti If you want this commit to be reverted please tell me!

tonyfoti commented 10 years ago

@andrewkhouzam If we are allowed to work after the sprint lots of problems would be handled. But I guess we are not allowed. And as I said I dont blame you in anything as we all made mistakes but just in the way you handled the problem.

andrewkhouzam commented 10 years ago

@tonyfoti I made no mistake deleting your css file. it is the last commit I could have made I had no time to handle the problem a better way! As the implementation and the reviewing should have been done in a better way! because the css files did not only destroy items html files, it destroyed the whole html files. As I see there was no reviewing and the coder did not even look in any other page except his page

But because It is your code I can revert my commit right now!

tonyfoti commented 10 years ago

@andrewkhouzam Fixing a certain issue by messing up with other parts is not a good solution, and deleting someone's else code without making him even review the changes was never a good solution too. And don't judge what other developers did as we all worked for the sake of the final product and no one was intending to only make his part work regardless of the other parts, as if at anytime someone's work caused a problem somewhere he would have fixed it. You were never asked to fix others' code, there was no time is then because we should have worked earlier than that putting into consideration such problems would happen.

sedramina commented 10 years ago

@tonyfoti check your code