yahoo / HaloDB

A fast, log structured key-value store.
https://yahoodevelopers.tumblr.com/post/178250134648/introducing-halodb-a-fast-embedded-key-value
Apache License 2.0
508 stars 100 forks source link

Merge tombstone files right after memory index is built #34

Closed wangtao724 closed 5 years ago

wangtao724 commented 5 years ago

@bellofreedom @amannaly @finaldie

Issue #, if available: As a DB specific cleanup job, mergeTombstoneFiles is only valuable at db open when isCleanUpTombstonesDuringOpen is true. So instead of exposing it to client, it makes more sense to keep it as internal procedure and do it with a background thread right after in-memory index is built in db open.

Description of changes:

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.