Closed liran-funaro closed 2 years ago
@sanastas
we have no good separation between Hash logic and Map logic
I think it is possible to attain this separation with not too much effort. If you find methods that should be moved like the ones you already mentioned, then let me know. Anyway, I won't start applying the changes you requested and merging with the master until we feel confident that we want to go ahead with this change.
I want to ask @boris-kap to make the review to this PR as well, so we have more then one opinion.
Broke down into number of PRs and rethink chunk/array design
EntryArray
and the rest of the logic intoChunk
.EntryArrayHeap
andEntryArrayDirect
implementingEntryArray
interface.OakSharedConfig
to pass Oak configuration between instances ofInternalOak
andChunks
.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.