search

yahoo / ember-gridstack

Ember components to build drag-and-drop multi-column grids powered by gridstack.js
https://yahoo.github.io/ember-gridstack/
Other
37 stars 29 forks source link

Fix conflicts with other jquery addons. #63

Closed ttill closed 4 years ago

ttill commented 4 years ago

See https://github.com/gridstack/gridstack.js/issues/1191

I experience the bug described above when using gridstack through ember-gridstack in an app which also uses other jquery addons.

For instance when trying to use ember-cli-bootstrap-datetimepicker: TypeError: $.fn.datetimepicker is undefined

Since gridstack.js uses jquery anyways for now, it shouldn't be a problem to add it our dependencies again for the time being.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

btecu commented 4 years ago

I've run into this issue as well, and I confirm the changes here fix the issue.

btecu commented 4 years ago

@balajimanoharan @jkusa what's the status here?

balajimanoharan commented 4 years ago

@ttill Thanks for this PR. I want to update the repo to allow for both, have config option jqueryIntegration: true|false that would package the appropriate js files. If you would like to add that to this PR, that would be great, otherwise I will work on that later this week.

btecu commented 4 years ago

@balajimanoharan It might not be worth it, since GridStack is actively working on dropping jQuery. Also, importing jQuery separately for now in Ember is trivial - maybe @ttill can add a note in the README instead?

ttill commented 4 years ago

Thanks for your feedback. I also do not think it is worth the effort, because