ISSUE-147 isChannelClosed should be public - Githubissues

yahoo / imapnio

Java imap nio client that is designed to scale well for thousands of connections per machine and reduce contention when using large number of threads and cpus.

57 stars 50 forks source link

ISSUE-147 isChannelClosed should be public #148

Closed chibenwa closed 1 year ago

chibenwa commented 1 year ago

Description

I would like to assert the state of a session before submitting requests to it.

Motivation and Context

IMAP provisionning script

How Has This Been Tested?

All tests passes

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Major release (change is NOT backward compatible with prior release)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

chibenwa commented 1 year ago

Hello @fansu

What's the ETA of this?

chibenwa commented 1 year ago

The last commit is an attempt to keep the test file below 2000 line of code and not trigger a checkstyle violation.