search

yahoo / jsx-test

An easy way to test your React Components (`.jsx` files).
Other
27 stars 17 forks source link

withContext deprecation #30

Open roderickhsiao opened 9 years ago

roderickhsiao commented 9 years ago

React 14 change to be parent base context and remove withContext method. https://facebook.github.io/react/docs/context.html

we should probably remove https://github.com/yahoo/jsx-test/blob/master/lib/helper.js#L128

@3den @mridgway

3den commented 8 years ago

@roderickhsiao I think we still need some way to pass the context to components being tested. We can keep the same api on jsx-test but change the implantation to support the new react style. Do you have some suggestion of how to do that?

akshayp commented 8 years ago

@roderickhsiao I'm not sure this needs to be removed. The way the withContext method in here is passing down the context is exactly how the docs describe. The method might be named poorly when compared to the withContext method in react but what it does within is still how react uses context in 0.14

roderickhsiao commented 8 years ago

thats true, probably only the naming suggest the old way react did.