search

yahoo / jsx-test

An easy way to test your React Components (`.jsx` files).
Other
27 stars 17 forks source link

Update help.js - replace deprecated functions #8

Closed tinorzldn closed 9 years ago

tinorzldn commented 9 years ago

Replacement of deprecated function getDOMNode by findDOMNode. Supporting ES6 based components (babel transformed or some other..) testing.

You can reproduce the problem with this replic of your example component and test in ES6: ES6 Component(use babel transform or some other): http://pastebin.com/dTsSyxYt Test: http://pastebin.com/3KcAU4ab

yahoocla commented 9 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

yahoocla commented 9 years ago

CLA is valid!

3den commented 9 years ago

@tinorzldn take a look at the suggestion above

tinorzldn commented 9 years ago

Yes, better that way :)

3den commented 9 years ago

Thanks for this PR the new version is 0.5.0 ;)