search

yahoo / kubectl-flame

Kubectl plugin for effortless profiling on kubernetes
Apache License 2.0
787 stars 94 forks source link

Upgrade to async-profiler 2 #62

Open loicmathieu opened 3 years ago

loicmathieu commented 3 years ago

Upgrade to async-profiler 2 for JVM application. Version 2 supports HTML flamegraph which are easier to use.

I can try to provide a PR if you point me in the right direction, if I undertand it correctly, the Docker container image should be updated to use the new version. By the way, you build async-profiler from the source from a forked repo and not the official one, is there a reason why ?

edeNFed commented 2 years ago

Yes, you got it right. The container that contains async-profiler is built here: https://github.com/yahoo/kubectl-flame/blob/master/agent/docker/jvm/Dockerfile

The fork repo is a workaround, back when I developed it async-profiler didn't work well with /tmp directory. If async-profiler version 2 works good we can remove this fork.