search

yahoo / kubectl-flame

Kubectl plugin for effortless profiling on kubernetes
Apache License 2.0
796 stars 96 forks source link

Java default event should be CPU not WALL #63

Closed loicmathieu closed 2 years ago

loicmathieu commented 3 years ago

As this is the default one from async-profiler. And it's also more useful on Java as wall clock profiling via async-profiler is a special mode and should also use the per-thread mode that is not activated: https://github.com/jvm-profiling-tools/async-profiler#wall-clock-profiling

I can provide a PR for it if you help me to start contributing ;)

edeNFed commented 3 years ago

Sounds good to me, I'll be happy to approve such PR 😄