search

yahoo / kubectl-flame

Kubectl plugin for effortless profiling on kubernetes
Apache License 2.0
796 stars 96 forks source link

feat: upgrade to async-profiler 2 #68

Open loicmathieu opened 3 years ago

loicmathieu commented 3 years ago

Fixes #62

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

loicmathieu commented 3 years ago

@edeNFed I try to update to async profiler 2 using the released artifact but I don't know exactly how to test it. I successfully build the images and the different cli but I don't know how to package them as a kubectl plugin, or at least test them in another way.

BasselAshi commented 2 years ago

Can you share how you compiled the code? I used go build cli/main.go but ended up getting stuck with Launching profiler ... when using the tool.

loicmathieu commented 2 years ago

Hi @BasselAshi I use go build too to compile the code but as said I have no idea how to test it so I didn't run it.

edeNFed commented 2 years ago

Hi @loicmathieu You can test this by using the --image flag. Simply upload your custom image to some registry and then invoke your compiled cli with: ./kubectl-flame --lang java <pod-name> -t 10s --image <image-name>

loicmathieu commented 2 years ago

Thanks @edeNFed I'll have a look next week

pvorb commented 2 years ago

@loicmathieu Is there any progress so far?

loicmathieu commented 2 years ago

@pvorb no, I didn't find the time to work on it yet.